feat: ✨ httpsign: newclient with timeout (#12)

* feat: ✨ httpsign: newclient with timeout Signed-off-by: thanhpp <[email protected]> * refactor: ♻️ rename option Signed-off-by: thanhpp <[email protected]> * test: ✅ httpsign: add option test Signed-off-by: thanhpp <[email protected]> --------- Signed-off-by: thanhpp <[email protected]>
KyberNetwork · Apr 22, 2023 · d531f50 · d531f50
1 parent d33901a
commit d531f50
Show file tree

Hide file tree

Showing 3 changed files with 40 additions and 2 deletions.
diff --git a/pkg/httpsign/options.go b/pkg/httpsign/options.go
@@ -0,0 +1,17 @@
+package httpsign
+
+import (
+	"net/http"
+	"time"
+)
+
+type Option func(c *http.Client)
+
+func WithTimeout(timeout time.Duration) Option {
+	return func(c *http.Client) {
+		if timeout == 0 {
+			return
+		}
+		c.Timeout = timeout
+	}
+}
diff --git a/pkg/httpsign/signclient.go b/pkg/httpsign/signclient.go
@@ -4,10 +4,20 @@ import (
 	"net/http"
 )
 
-func NewClient(transport http.RoundTripper, key string, secret []byte) *http.Client {
-	return &http.Client{
+func NewClient(transport http.RoundTripper, key string, secret []byte, opts ...Option) *http.Client {
+	c := &http.Client{
 		Transport: NewTransport(transport, key, secret),
 	}
+
+	for i := range opts {
+		if opts[i] == nil {
+			continue
+		}
+
+		opts[i](c)
+	}
+
+	return c
 }
 
 func NewTransport(inner http.RoundTripper, key string, secret []byte) HTTPSign {

diff --git a/pkg/httpsign/signclient_test.go b/pkg/httpsign/signclient_test.go
@@ -4,8 +4,10 @@ import (
 	"io"
 	"net/http"
 	"testing"
+	"time"
 
 	"github.com/KyberNetwork/tradinglib/pkg/httpsign"
+	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
 )
 
@@ -24,3 +26,12 @@ func TestRequest(t *testing.T) {
 	require.NoError(t, err)
 	t.Log(string(out))
 }
+
+func TestOption(t *testing.T) {
+	timeout := time.Second * 3
+
+	client := httpsign.NewClient(
+		http.DefaultTransport, "..", []byte(".."), httpsign.WithTimeout(timeout),
+	)
+	assert.Equal(t, client.Timeout, timeout)
+}