fix: 🩹 mev: blxrResponse

Signed-off-by: thanhpp <[email protected]>
KyberNetwork · Jan 11, 2024 · 0a1c340 · 0a1c340
1 parent 32257f1
commit 0a1c340
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 4 deletions.
diff --git a/pkg/mev/bloxroute_submit_bundle.go b/pkg/mev/bloxroute_submit_bundle.go
@@ -83,7 +83,7 @@ func (s *BloxrouteClient) SendBundle(
 		return SendBundleResponse{}, fmt.Errorf("new http request error: %w", err)
 	}
 
-	resp, err := doRequest[SendBundleResponse](s.c, httpReq, [2]string{"Authorization", s.auth})
+	resp, err := doRequest[BLXRSubmitBundleResponse](s.c, httpReq, [2]string{"Authorization", s.auth})
 	if err != nil {
 		return SendBundleResponse{}, err
 	}
@@ -93,7 +93,7 @@ func (s *BloxrouteClient) SendBundle(
 			resp.Error.Code, resp.Error.Messange)
 	}
 
-	return resp, nil
+	return SendBundleResponse(resp), nil
 }
 
 type BLXRSubmitBundleRequest struct {
@@ -129,6 +129,13 @@ func (p *BLXRSubmitBundleParams) SetBlockNumber(block uint64) *BLXRSubmitBundleP
 	return p
 }
 
+type BLXRSubmitBundleResponse struct {
+	Jsonrpc string           `json:"jsonrpc,omitempty"`
+	ID      int              `json:"id,string,omitempty"`
+	Result  SendBundleResult `json:"result,omitempty"`
+	Error   SendBundbleError `json:"error,omitempty"`
+}
+
 func bloxrouteSignFlashbot(key *ecdsa.PrivateKey, p *BLXRSubmitBundleParams) (string, error) {
 	param := new(SendBundleParams)
 	param.Txs = p.Transaction

diff --git a/pkg/mev/pkg.go b/pkg/mev/pkg.go
@@ -82,7 +82,7 @@ func doRequest[T any](c *http.Client, req *http.Request, headers ...[2]string) (
 
 type SendBundleResponse struct {
 	Jsonrpc string           `json:"jsonrpc,omitempty"`
-	ID      int              `json:"id,string,omitempty"`
+	ID      int              `json:"id,omitempty"`
 	Result  SendBundleResult `json:"result,omitempty"`
 	Error   SendBundbleError `json:"error,omitempty"`
 }

diff --git a/pkg/mev/send_bundle_test.go b/pkg/mev/send_bundle_test.go
@@ -66,7 +66,7 @@ func TestSendBundle(t *testing.T) {
 func TestUnmarshal(t *testing.T) {
 	var (
 		data = "{\"id\":\"1\",\"result\":{\"bundleHash\":\"0xe0e0592348830d57fac820a6bec9fdbf0ac20a2b503351c63217cf8c274b70a8\"},\"jsonrpc\":\"2.0\"}\n" // nolint:lll
-		resp mev.SendBundleResponse
+		resp mev.BLXRSubmitBundleResponse
 	)
 
 	require.NoError(t, json.Unmarshal([]byte(data), &resp))