Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes several connection related issues #360

Merged
merged 2 commits into from
Jun 20, 2024
Merged

Fixes several connection related issues #360

merged 2 commits into from
Jun 20, 2024

Conversation

ecmel
Copy link
Collaborator

@ecmel ecmel commented Jun 20, 2024 •
edited
Loading

Changes introduced by this PR

  • 500 ms interval when executing query on KDB+ connections reduced to 50 ms
  • Connection names are not case sensitive any more
  • Same address can be used under different connection names
  • Add authentication implemented for KDB+ connections which asks for credentials
  • Connection settings in settings.json is now manually editable
  • Changes are backwards compatible, user's current settings work as is

@ecmel ecmel self-assigned this Jun 20, 2024
@ecmel ecmel marked this pull request as ready for review June 20, 2024 11:40
@ecmel ecmel requested a review from Philip-Carneiro-KX June 20, 2024 11:40
@ecmel ecmel marked this pull request as draft June 20, 2024 11:44
@kx-sonarqube
Copy link

kx-sonarqube bot commented Jun 20, 2024

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
84.8% 84.8% Coverage on New Code
0.0% 0.0% Duplication on New Code

See analysis details on SonarQube

@ecmel ecmel marked this pull request as ready for review June 20, 2024 11:50
@ecmel ecmel merged commit c2d5fa0 into dev Jun 20, 2024
5 checks passed
@ecmel ecmel deleted the ee-conn branch June 20, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Philip-Carneiro-KX Philip-Carneiro-KX Philip-Carneiro-KX approved these changes

@Philip-Carneiro Philip-Carneiro Philip-Carneiro approved these changes

Assignees

@ecmel ecmel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ecmel @Philip-Carneiro @Philip-Carneiro-KX