Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KXI-46528: Regression: Import old style data sources into .kx folder #313

Merged
merged 1 commit into from
May 22, 2024
Merged

KXI-46528: Regression: Import old style data sources into .kx folder #313

merged 1 commit into from
May 22, 2024

Conversation

ecmel
Copy link
Collaborator

@ecmel ecmel commented May 22, 2024

Changes introduced by this PR

  • Imports old style datasources into workspace .kx folder

Question:

  • Should we import into a dedicated forder under .kx using original data source file name(.kdb.json) ? This way user can easily find them.

@kx-sonarqube
Copy link

kx-sonarqube bot commented May 22, 2024

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
100.0% 100.0% Coverage on New Code
0.0% 0.0% Duplication on New Code

See analysis details on SonarQube

@ecmel ecmel marked this pull request as ready for review May 22, 2024 09:28
@ecmel ecmel requested a review from Philip-Carneiro-KX May 22, 2024 09:28
@ecmel ecmel self-assigned this May 22, 2024
@ecmel ecmel merged commit a10d52f into dev May 22, 2024
5 checks passed
@ecmel ecmel deleted the KXI-46528 branch May 22, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Philip-Carneiro-KX Philip-Carneiro-KX Philip-Carneiro-KX approved these changes

Assignees

@ecmel ecmel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ecmel @Philip-Carneiro-KX