Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] KXI-38369: Multiple scratchpads and workspace data sources UI #275

Merged
merged 35 commits into from
May 8, 2024
Merged

[WIP] KXI-38369: Multiple scratchpads and workspace data sources UI #275

merged 35 commits into from
May 8, 2024

Conversation

ecmel
Copy link
Collaborator

@ecmel ecmel commented Apr 15, 2024

Changes introduced by this PR

  • Implemented custom editor for data source json files in workspace
  • Implemented data sources explorer UI
  • Implemented scratchpads explorer UI
  • Implemented connection association for scratchpads
  • Supports python and q scratchpads

@ecmel ecmel self-assigned this Apr 15, 2024
ecmel and others added 28 commits April 15, 2024 14:41
@ecmel
fixed test
6e2dff7
@ecmel
add watcher and sort
400b01c
@ecmel
implemented code lens
0a9e4b3
@ecmel
use vscode icons
a88f16d
@Philip-Carneiro-KX
scratchpad status icon and status methods
8c4cf85
@ecmel
Merge remote-tracking branch 'origin/dev' into multiple-sp
49d09ee
@ecmel
cleanup activationEvents
353ade4
@ecmel
fixes KXI-38122, KXI-36434, KXI-37785, KXI-41647
fb6336d
@ecmel
working draft
fae17e0
@ecmel
use more of connection service
b68ac67
@ecmel
added icons
9120457
@ecmel
Merge remote-tracking branch 'origin/dev' into multiple-sp
6eb552c
@ecmel
fixed tests
3a38acb
@ecmel
refactor test to use ext.activeTextEditor
4faa7bb
@ecmel
support for all run commands added for ssratchpads
032bbb0
@ecmel
checkpoint before ws datasource
65b3d0c
@ecmel
organized code
8f8b8ab
@Philip-Carneiro-KX
add ds icons
d75bb75
@ecmel
fixed multiple workspace issue
442121d
@ecmel
KXI-37408
140435f
@ecmel
automatic updates for datasource
87c489e
@ecmel
ability to add python sp
a741b1a
@ecmel
call update after commands
0c2c817
@ecmel
use value props in webview
c58c471
@ecmel
do not modify connect
5e20fb1
@ecmel
increase coverage
c1646a4
@ecmel
Merge remote-tracking branch 'origin/dev' into multiple-sp
d9d9a76
@ecmel
fixed the merge
853b6b5
@ecmel ecmel marked this pull request as ready for review May 8, 2024 09:45
@kx-sonarqube
Copy link

kx-sonarqube bot commented May 8, 2024

Quality Gate passed Quality Gate passed

The SonarQube Quality Gate passed, but some issues were introduced.

28 New issues
0 Security Hotspots
81.5% 81.5% Coverage on New Code
0.0% 0.0% Duplication on New Code

See analysis details on SonarQube

@ecmel ecmel merged commit ff3a8a6 into dev May 8, 2024
5 checks passed
@ecmel ecmel deleted the multiple-sp branch May 13, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Philip-Carneiro-KX Philip-Carneiro-KX Philip-Carneiro-KX approved these changes

@nfarrell-kx nfarrell-kx Awaiting requested review from nfarrell-kx

Assignees

@ecmel ecmel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ecmel @Philip-Carneiro-KX