Merge pull request #302 from KxSystems/insights-conn-active

smallfix for insights active connection
KxSystems · May 16, 2024 · 991d797 · 991d797
2 parents d091609 + e90fea8
commit 991d797
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 0 deletions.
diff --git a/src/services/connectionManagerService.ts b/src/services/connectionManagerService.ts
@@ -253,6 +253,9 @@ export class ConnectionManagementService {
       ext.activeConnection = undefined;
       ext.connectionNode = undefined;
       commands.executeCommand("setContext", "kdb.connected.active", false);
+      if (connType === "Insights") {
+        commands.executeCommand("setContext", "kdb.insightsConnected", false);
+      }
     }
     Telemetry.sendEvent("Connection.Disconnected." + connType);
     ext.outputChannel.appendLine(

diff --git a/test/suite/services.test.ts b/test/suite/services.test.ts
@@ -991,6 +991,24 @@ describe("connectionManagerService", () => {
       assert.equal(ext.activeConnection, undefined);
       assert.equal(ext.connectionNode, undefined);
     });
+
+    it("disconnectBehaviour with IOnsights connection", () => {
+      ext.connectedConnectionList.push(insightsConn);
+      ext.activeConnection = insightsConn;
+
+      connectionManagerService.disconnectBehaviour(insightsConn);
+      assert.equal(ext.connectedConnectionList.length, 0);
+      assert.equal(ext.activeConnection, undefined);
+      assert.equal(ext.connectionNode, undefined);
+    });
+
+    it("disconnectBehaviour with no active connection", () => {
+      ext.connectedConnectionList.push(insightsConn);
+
+      connectionManagerService.disconnectBehaviour(insightsConn);
+      assert.equal(ext.connectedConnectionList.length, 0);
+      assert.equal(ext.activeConnection, undefined);
+    });
   });
 
   describe("resetScratchpad", () => {