Skip to content

Commit

Permalink
remove some todos
Browse files Browse the repository at this point in the history
  • Loading branch information
Philip-Carneiro-KX committed Jun 5, 2024
1 parent 01df370 commit 96e7a30
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 4 deletions.
8 changes: 6 additions & 2 deletions src/commands/serverCommand.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ import {
getInsights,
getServerName,
getServers,
kdbOutputLog,
updateInsights,
updateServers,
} from "../utils/core";
Expand Down Expand Up @@ -337,7 +338,10 @@ export async function executeQuery(
window.showErrorMessage(
"No active connection found. Connect to one connection.",
);
//TODO ADD ERROR TO CONSOLE HERE
kdbOutputLog(
"No active connection found. Connect to one connection.",
"ERROR",
);
return undefined;
} else {
connLabel = ext.activeConnection.connLabel;
Expand All @@ -346,7 +350,7 @@ export async function executeQuery(
const isConnected = connMngService.isConnected(connLabel);
if (!isConnected) {
window.showInformationMessage("The selected connection is not connected.");
//TODO ADD ERROR TO CONSOLE HERE
kdbOutputLog("The selected connection is not connected.", "ERROR");
return undefined;
}

Expand Down
4 changes: 2 additions & 2 deletions src/services/dataSourceEditorProvider.ts
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ import {
import { InsightsConnection } from "../classes/insightsConnection";
import { MetaObjectPayload } from "../models/meta";
import { ConnectionManagementService } from "./connectionManagerService";
import { offerConnectAction } from "../utils/core";
import { kdbOutputLog, offerConnectAction } from "../utils/core";

export class DataSourceEditorProvider implements CustomTextEditorProvider {
public filenname = "";
Expand Down Expand Up @@ -92,7 +92,7 @@ export class DataSourceEditorProvider implements CustomTextEditorProvider {
);
meta = Promise.resolve(<MetaObjectPayload>{});
this.cache.set(connLabel, meta);
//TODO ADD ERROR TO CONSOLE HERE
kdbOutputLog("No database running in this Insights connection.", "ERROR");
}
return (await meta) || Promise.resolve(<MetaObjectPayload>{});
}
Expand Down

0 comments on commit 96e7a30

Please sign in to comment.