fix: 댓글 생성, 조회 수정 #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlarbals824
reviewed
Mar 5, 2024
| @GetMapping("/all") | ||
| public ResponseEntity<List<CommentDetail>> getAllComments() { | ||
| List<CommentDetail> comments = commentService.getAllComments(); | ||
| public ResponseEntity<List<CommentDetail>> getAllComments(@RequestParam Long advertiseId) { |
There was a problem hiding this comment.
path variable을 사용하는게 좀 더 깔끔할것같아 url도 /api/advertises/comments/{advertiseId} 이런느낌으로 자원을 명시해주는게 좀 더 좋을것같아
| return comments.stream() | ||
| .map(comment -> new CommentDetail(comment.getCommentId(), comment.getContent(), comment.getCommenterId())) | ||
| .map(comment -> new CommentDetail(comment.getCommentId(), comment.getContent())) |
There was a problem hiding this comment.
와이어프레임에 댓글 작성자 이름도 있어서 email이라도 간단하게 적어주면 좋을 것 같아
tlarbals824
reviewed
Mar 5, 2024
| public ResponseEntity<List<CommentDetail>> getAllComments() { | ||
| List<CommentDetail> comments = commentService.getAllComments(); | ||
| @Operation(summary = "댓글 조회") | ||
| @GetMapping("comments/{advertiseId}") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
댓글 생성
userId 요청 제거
댓글 조회
요청변수로 advertiseId