POC for ssm parameter tokens #2
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeswiggin
reviewed
Apr 25, 2019
|
Yeah. @jwiggins78 I might need help with how to find the correct role and such since I'm still a little fuzzy on that. Also I still need to test this. Am curious if you have any feedback on the approach to caching or if there is any way to make it more resilient... |
|
As you test and work against policies that don't allow the assumption, you'll see that you will have uncaught promise exceptions.... maybe a catch on there somewhere will be appropriate to throw a known error type? Otherwise, I think the caching is fine. I'd be happy to pair with you to help describe the requirements of setting up the roles for assumption to work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.