Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy queries from KREAd frontend #127

Merged
merged 3 commits into from
Apr 8, 2024

Conversation

Jorge-Lopes
Copy link

@Jorge-Lopes Jorge-Lopes commented Apr 4, 2024

Description

The purpose of this PR is to update the KREAd frontend code to use the JSON API instead of the deprecated RPC method to query the Vstorage.

With this in mind, it was necessary to update the @agoric/rpc and @agoric/web-components packages, and the respective imported functions being used by KREAd.

Changes made to original code:

  • At commit 5c6bdaf the packages mentioned above are updated to the latest version.
  • At commit 42f886f
    • the fetchChainInfo function is updated to return the api along with the rpc and chainName
    • the connectAgoric function is updated to pass the rpc as argument to makeAgoricWalletConnection
    • the startWatching function is updated to pass the api as argument to makeAgoricChainStorageWatcher
  • At commit fbeeedb on all calls of the watchLatest method of chainStorageWatcher, the onError argument was removed, since it is no longer expected.

Related Issues

Fixes the following issues:

Checklist

Make sure all items are checked before submitting the pull request. Remove any items that are not applicable.

  • The PR title is clear and concise.
  • Are there changes in the /fronted folder? Make sure cd frontend && yarn build runs successfully.;

@WietzeSlagman WietzeSlagman merged commit 6218eab into Kryha:main Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants