Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Medium: Item market average level metric is incorrect #61

Closed
4 tasks
Pandelissym opened this issue Oct 18, 2023 · 0 comments · Fixed by #63
Closed
4 tasks

Bug: Medium: Item market average level metric is incorrect #61

Pandelissym opened this issue Oct 18, 2023 · 0 comments · Fixed by #63
Assignees
@Pandelissym
Labels
bug Something isn't working

Comments

@Pandelissym
Copy link
Contributor

Pandelissym commented Oct 18, 2023 •
edited
Loading

Description:

The average market level metric for items is incorrect. The average is updated incorrectly. Could be linked to #53 if the update operation makes the contract function error and not complete all required steps.

Repro

  • View statistics
  • See that they are not correct

Acceptance criteria
@Pandelissym Pandelissym added the bug Something isn't working label Oct 18, 2023
@Pandelissym Pandelissym self-assigned this Oct 18, 2023
@carlos-kryha carlos-kryha mentioned this issue Oct 18, 2023
Closed
4 tasks
@Pandelissym Pandelissym mentioned this issue Oct 20, 2023
Merged
@Pandelissym Pandelissym linked a pull request Oct 20, 2023 that will close this issue
Fix marketplaceAverageLevel metric #63
Merged
Pandelissym added a commit that referenced this issue Oct 20, 2023
@Pandelissym
Fix marketplaceAverageLevel metric (#63)
31ae801 
Fixed marketplaceAverageLevel metric. For items, this metric was being
calculated incorrectly. This lead to specific cases where the metric
might become a negative value after updating. This would violate the
typeguard of the metric which expects it to be greater or equal than 0
and an error would be thrown. This means the buy item flow would not
complete hence why the item would still remain in the market state.

Fixes 2 bugs:
1. #61 
2. #53

Co-authored-by: Pandelis Symeonidis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pandelissym Pandelissym

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix marketplaceAverageLevel metric Kryha/KREAd
1 participant
@Pandelissym