Bug: Critical: Item market entry remains in market storage node upon succesful buyItem call

[carlos-kryha]

Description

We encountered this issue when purchasing a legendary hair item, the buy flow worked as expected (item was moved to buyers wallet, displayed in inventory, and can be equipped/unequipped). The market entry however, remains in the market path on the storageNode despite having been sold. This results in a "ghost" entry that can never be bought since the item is no longer on contract.

To be clear: this bug does not compromise offer safety nor does it allow unwanted behavior in regards to token transfers. It simply polutes the market list with entries that are no longer available.

Repro steps

The cause of the bug is unclear and there's currently no way to reproduce it consistently
That being said, I can verify the following market entry has been correctly fulfilled, and remains in the storageNode

Acceptance criteria

• understand what causes the bug
• implement fix
• test fix on emerynet
• determine effort to find and remove affected entries

[carlos-kryha]

Code from #61 is called in the buyFirstSaleItem flow after the reallocation is completed and before the removal of the market entry. We suspect #61 is causing the buy call to error out, preventing the code that removes the entry from the market from running.
https://github.com/Kryha/KREAd/blob/develop/agoric/contract/src/kreadKit.js#L1357

[carlos-kryha]

@Pandelissym was able to reproduce this locally. After validating the offers and reallocating the assets, the buyItem fn runs the following code:

          // Update metrics
          marketFacet.updateMetrics('item', {
            marketplaceAverageLevel: {
              type: 'remove',
              value: sellRecord.asset.level,
            },
          });

          // Remove market entry
          market.itemEntries.delete(sellRecord.id);
          void marketFacet.deleteNode(
            sellRecord.recorderKit.recorder.getStorageNode(),
          );

#61 can cause marketFacet.updateMetrics() to result in a negative marketplaceAverageLevel. This is then rejected by the following guard:

          marketplaceAverageLevel: M.splitRecord({
                type: M.or('add', 'remove'),
                value: M.gte(0),
          }),

Since marketFacet.updateMetrics() fails, the code responsible for removing the market entry is never executed