Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(Notes): Remove default access level from global notes #1507

Merged
merged 1 commit into from
Nov 9, 2024

Conversation

Kruptein
Copy link
Owner

@Kruptein Kruptein commented Nov 9, 2024

Notes can be shared with other players using the access tab. Sometimes you just want to quickly share with all players and the 'default' access row that we currently have is very nice for that.

For local notes this is very intuitive. It shares whatever access rights the default row has with all players in the campaign.

For global notes this is less intuitive, because there is no real link to a campaign and thus to a set of default players. The global note might be used in multiple campaigns with a variety of players. It has no home campaign.

This leads us to the present day where a global note with default access actually is shared with all users on the server. This is not really ideal, so this PR removes the default access row for global notes. Where necessary share global notes with specific users. The access UI has an interaction label to select all users in the current campaign, so it should not really impose much trouble.

It's currently resolved without a migration and simply hard filtered on the server.

@Kruptein Kruptein merged commit 5221159 into dev Nov 9, 2024
5 checks passed
@Kruptein Kruptein deleted the bugfix/remove-global-access branch November 9, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant