bug(Notes): Remove default access level from global notes #1507
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes can be shared with other players using the access tab. Sometimes you just want to quickly share with all players and the 'default' access row that we currently have is very nice for that.
For local notes this is very intuitive. It shares whatever access rights the default row has with all players in the campaign.
For global notes this is less intuitive, because there is no real link to a campaign and thus to a set of default players. The global note might be used in multiple campaigns with a variety of players. It has no home campaign.
This leads us to the present day where a global note with default access actually is shared with all users on the server. This is not really ideal, so this PR removes the default access row for global notes. Where necessary share global notes with specific users. The access UI has an interaction label to select all users in the current campaign, so it should not really impose much trouble.
It's currently resolved without a migration and simply hard filtered on the server.