Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GeoMechanicsApplication] Create 3d line piping element 3d2n #12857

Merged
merged 10 commits into from
Nov 21, 2024
Merged

[GeoMechanicsApplication] Create 3d line piping element 3d2n #12857

merged 10 commits into from
Nov 21, 2024

Conversation

rfaasse
Copy link
Contributor

@rfaasse rfaasse commented Nov 19, 2024 •
edited
Loading

📝 Description
Adds a 3d version of the piping line element with unit tests and an integration test

@rfaasse rfaasse linked an issue Nov 19, 2024 that may be closed by this pull request
[GeoMechanicsApplication] Create 3D line piping element 3D2N #12824
Closed
@rfaasse rfaasse self-assigned this Nov 19, 2024
@rfaasse rfaasse added the GeoMechanics Issues related to the GeoMechanicsApplication label Nov 19, 2024
@rfaasse rfaasse marked this pull request as ready for review November 19, 2024 10:39
WPK4FEM
WPK4FEM reviewed Nov 19, 2024
View reviewed changes
Copy link
Contributor

@WPK4FEM WPK4FEM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The thing that is not here yet is an integration test, which should end up in the validation suite that seldomly runs because they take a lot of time.

applications/GeoMechanicsApplication/custom_elements/geo_steady_state_Pw_piping_element.h Show resolved Hide resolved
...ation/custom_strategies/strategies/geo_mechanics_newton_raphson_erosion_process_strategy.hpp Outdated Show resolved Hide resolved
...echanicsApplication/tests/cpp_tests/custom_elements/test_geo_steady_state_piping_element.cpp Outdated Show resolved Hide resolved
markelov208
markelov208 reviewed Nov 19, 2024
View reviewed changes
Copy link
Contributor

@markelov208 markelov208 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Richard, thank you for a nice piece of work. I was wondering shall PIPE_WIDTH_FACTOR have its own unit test? Formally, it is checked already with left/right hand sides.

...ation/custom_strategies/strategies/geo_mechanics_newton_raphson_erosion_process_strategy.hpp
@@ -67,6 +67,24 @@ class GeoMechanicsNewtonRaphsonErosionProcessStrategy
mPipingIterations = rParameters["max_piping_iterations"].GetInt();
}

template <typename PipingElementType>
std::optional<std::vector<PipingElementType*>> TryDownCastToPipingElement(const std::vector<Element*>& rPipeElements)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to have one function for all three cases. I think it useful to pass the pipe element name for the error message.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice suggestion, I added the name of the element to the error message, by using the element->Info(), and implemented them in the relevant elements.

WPK4FEM
WPK4FEM reviewed Nov 20, 2024
View reviewed changes
Copy link
Contributor

@WPK4FEM WPK4FEM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more remarks now the integration test is added.

applications/GeoMechanicsApplication/tests/three_dimensional_piping/MaterialParameters.json Outdated Show resolved Hide resolved
applications/GeoMechanicsApplication/tests/three_dimensional_piping/ProjectParameters.json Show resolved Hide resolved
applications/GeoMechanicsApplication/tests/three_dimensional_piping/ProjectParameters.json Outdated Show resolved Hide resolved
applications/GeoMechanicsApplication/tests/three_dimensional_piping/ProjectParameters.json Outdated Show resolved Hide resolved
applications/GeoMechanicsApplication/tests/three_dimensional_piping/ProjectParameters.json Outdated Show resolved Hide resolved
rfaasse
rfaasse commented Nov 21, 2024
View reviewed changes
Copy link
Contributor Author

@rfaasse rfaasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the reviews, I think I processed all comments, let me know if it's done satisfactory!

...ation/custom_strategies/strategies/geo_mechanics_newton_raphson_erosion_process_strategy.hpp Outdated Show resolved Hide resolved
applications/GeoMechanicsApplication/tests/three_dimensional_piping/MaterialParameters.json Outdated Show resolved Hide resolved
applications/GeoMechanicsApplication/tests/three_dimensional_piping/ProjectParameters.json Outdated Show resolved Hide resolved
applications/GeoMechanicsApplication/tests/three_dimensional_piping/ProjectParameters.json Outdated Show resolved Hide resolved
applications/GeoMechanicsApplication/tests/three_dimensional_piping/ProjectParameters.json Outdated Show resolved Hide resolved
...echanicsApplication/tests/cpp_tests/custom_elements/test_geo_steady_state_piping_element.cpp Outdated Show resolved Hide resolved
applications/GeoMechanicsApplication/custom_elements/geo_steady_state_Pw_piping_element.h Show resolved Hide resolved
...ation/custom_strategies/strategies/geo_mechanics_newton_raphson_erosion_process_strategy.hpp
@@ -67,6 +67,24 @@ class GeoMechanicsNewtonRaphsonErosionProcessStrategy
mPipingIterations = rParameters["max_piping_iterations"].GetInt();
}

template <typename PipingElementType>
std::optional<std::vector<PipingElementType*>> TryDownCastToPipingElement(const std::vector<Element*>& rPipeElements)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice suggestion, I added the name of the element to the error message, by using the element->Info(), and implemented them in the relevant elements.

applications/GeoMechanicsApplication/tests/three_dimensional_piping/ProjectParameters.json Show resolved Hide resolved
WPK4FEM
WPK4FEM approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@WPK4FEM WPK4FEM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank for taking up the suggestions and extending piping to 3D for line elements.
Looks good to go for me.

@rfaasse rfaasse merged commit 2d0705e into master Nov 21, 2024
11 checks passed
@rfaasse rfaasse deleted the geo/12824-create-3d-line-piping-element-3d2n branch November 21, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WPK4FEM WPK4FEM WPK4FEM approved these changes

@avdg81 avdg81 Awaiting requested review from avdg81

@markelov208 markelov208 Awaiting requested review from markelov208

Assignees

@rfaasse rfaasse

Labels
GeoMechanics Issues related to the GeoMechanicsApplication
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[GeoMechanicsApplication] Create 3D line piping element 3D2N
3 participants
@rfaasse @WPK4FEM @markelov208