Added consistency in inner_radius for pie charts serie graph #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yobuntu
force-pushed
the
consistent_hole
branch
from
d41e5a1
to
bb0b183
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @paradoxxxzero , I hope you are doing well :)
This PR should add some consistency in
inner_radiussettings for series pie chart.And so we can have double donut charts !
It should break the second test of pygal/test/test_pie.py, which should test that this does not works (why ?) but that does really only assert PieChart.render() doen't raise an error. so i didn't test anything more as i dont really know what is the policy.
Cheers