-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(plugin/redirect): plugin to redirect requests to a new location #13900
Conversation
c16e41b
to
90527ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 🚀 !
It's also an interesting argument towards some sort of plugin piping (combining plugins).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good enough to me, minor cosmetic comment
@@ -43,6 +43,7 @@ local plugins = { | |||
"ai-request-transformer", | |||
"ai-response-transformer", | |||
"standard-webhooks", | |||
"redirect" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"redirect" | |
"redirect", |
Cherry-pick failed for Please cherry-pick the changes locally. git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-13900-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-13900-to-master-to-upstream
git checkout -b cherry-pick-13900-to-master-to-upstream
ancref=$(git merge-base 7d2f2c1354453318b16f73fccd2c9b9cf0a7e7ae 030454704e5f35a96db19e2d64b38ebc65926349)
git cherry-pick -x $ancref..030454704e5f35a96db19e2d64b38ebc65926349 |
Summary
Adds a new plugin that allows users to return a
Location
header on a given entity.This use case can currently be met with the
request-termination
andexit-transformer
plugins, but it's a common workflow that we should support as a first class citizen.Docs are pending - If this PR is deemed acceptable I can submit a docs PR before merge
Checklist
changelog/unreleased/kong
orskip-changelog
label added on PR if changelog is unnecessary. README.md