Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(clustering): start/stop when incremental on #13852

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

chronolaw
Copy link
Contributor

@chronolaw chronolaw commented Nov 9, 2024

Summary

KAG-5749

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[issue number]

@github-actions github-actions bot added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Nov 9, 2024
@chronolaw chronolaw marked this pull request as ready for review November 9, 2024 04:25
Copy link
Contributor

@chobits chobits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, we fixed this case now, I remember we already have a kag to track this test case before.

@ADD-SP ADD-SP merged commit a1a6f63 into master Nov 11, 2024
41 checks passed
@ADD-SP ADD-SP deleted the tests/start_stop_for_inc_sync branch November 11, 2024 07:49
@team-gateway-bot
Copy link
Collaborator

Cherry-pick failed for master, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-13852-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-13852-to-master-to-upstream
git checkout -b cherry-pick-13852-to-master-to-upstream
ancref=$(git merge-base 7e9dbf99f1dc577556e9dba07d739883939ae22d 6c8f3a44dec16fd83c06e65116de1fdd76b7ff03)
git cherry-pick -x $ancref..6c8f3a44dec16fd83c06e65116de1fdd76b7ff03

@github-actions github-actions bot added the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Nov 11, 2024
@kikito kikito removed the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee size/S skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants