fix(clustering): report node version in sync

[chronolaw]

Summary

May change after KAG-5369 and #13887
KAG-5772

Checklist

• The Pull Request has tests
• A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
• There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[issue number]

[dndx]

This does not seems to be the right approach, it should ideally be done as part of "RPC handshake method change" work, as node version will not change between calls.

[chronolaw]

@dndx I have changed the implementation, could you take a look again? thanks.

[StarlightIbuki]

This does not seems to be the right approach, it should ideally be done as part of "RPC handshake method change" work, as node version will not change between calls.

+1. Please consider redesign the solution

[chobits]

For other reviewers, if assertion failed, it will break up a single timer runtime, so it's safe for CP.

• kong/clustering/rpc//socket.lua: callback is runned in a timer

        -- call dispatch
        local res, err = kong.timer:named_at(string_format("JSON-RPC callback for node_id: %s, id: %d, method: %s",
                                                           self.node_id, payload.id, payload.method),
                                                           0, _M._dispatch, self, dispatch_cb, payload)

[StarlightIbuki]

This seems to be going to be covered by a new change. Are we going to close this?

[chronolaw]

This seems to be going to be covered by a new change. Are we going to close this?

This PR is re-implemented to work with meta rpc call.

[chronolaw]

@dndx , could you take a look and approve it? thanks.