fix: do not reconcile gateways with unsupported gw class #711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czeslavo
force-pushed
the
fix/not-supported-gwclass
branch
from
4fd90da to
697f27b
Compare
czeslavo
force-pushed
the
fix/not-supported-gwclass
branch
from
697f27b to
5796446
Compare
czeslavo
force-pushed
the
fix/not-supported-gwclass
branch
5 times, most recently
from
7ac3fd7 to
31466a4
Compare
czeslavo
force-pushed
the
fix/not-supported-gwclass
branch
from
31466a4 to
71f4f3d
Compare
programmer04
reviewed
Oct 8, 2024
Co-authored-by: Jakub Warczarek <[email protected]>
pmalek
approved these changes
Oct 8, 2024
pmalek
pushed a commit
that referenced
this pull request
Oct 8, 2024
* fix: do not reconcile gateways with unsupported gw class * Apply suggestions from code review Co-authored-by: Jakub Warczarek <[email protected]> --------- Co-authored-by: Jakub Warczarek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Ensures that if the
Gatewaydoes not refer to a supportedGatewayClass(we can successfully get it and verify theControllerNamematches the KGO's one), we won't reconcile it and mark it with the Gateway finalizers.Which issue this PR fixes
Fixes #586.
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect significant changes