Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make object counter conditional on CRD existence #710

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented Oct 7, 2024

What this PR does / why we need it:

Fixes #448

@pmalek pmalek added this to the KGO v1.4.x milestone Oct 7, 2024
@pmalek pmalek self-assigned this Oct 7, 2024
@pmalek pmalek force-pushed the object-counters-conditional-based-on-crd-existence branch 3 times, most recently from 5c85628 to 201fe02 Compare October 8, 2024 08:15
@pmalek pmalek marked this pull request as ready for review October 8, 2024 08:28
@pmalek pmalek requested a review from a team as a code owner October 8, 2024 08:28
Copy link
Contributor

@czeslavo czeslavo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be changelog-worthy, no? We're adding new datapoints for the controllers and fixing a bug.

@pmalek
Copy link
Member Author

pmalek commented Oct 8, 2024

This might be changelog-worthy, no? We're adding new datapoints for the controllers and fixing a bug.

I've mentioned the change in 633d5c9. WDYT?

@pmalek pmalek enabled auto-merge (squash) October 8, 2024 08:52
@pmalek pmalek force-pushed the object-counters-conditional-based-on-crd-existence branch from 633d5c9 to 275d5a5 Compare October 8, 2024 09:05
@pmalek pmalek requested a review from czeslavo October 8, 2024 09:05
@pmalek pmalek merged commit 10d0539 into main Oct 8, 2024
21 checks passed
@pmalek pmalek deleted the object-counters-conditional-based-on-crd-existence branch October 8, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make object counters conditional on the presence of CRDs in the cluster
2 participants