Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: fix HTTPRoute update in KongPluginInstallation integration test #701

Merged
merged 1 commit into from
Oct 4, 2024
Merged

tests: fix HTTPRoute update in KongPluginInstallation integration test #701

merged 1 commit into from
Oct 4, 2024

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented Oct 4, 2024

What this PR does / why we need it:

Fix an Update of HTTPRoute which might result in https://github.com/Kong/gateway-operator/actions/runs/11179695772/job/31079877922#step:5:514

    test_kongplugininstallation.go:332: 
        	Error Trace:	/home/runner/work/gateway-operator/gateway-operator/test/integration/test_kongplugininstallation.go:332
        	            				/home/runner/work/gateway-operator/gateway-operator/test/integration/test_kongplugininstallation.go:92
        	Error:      	Received unexpected error:
        	            	Operation cannot be fulfilled on httproutes.gateway.networking.k8s.io "6a2edf61-4206-4e08-a695-ede056813fbd": the object has been modified; please apply your changes to the latest version and try again
        	Test:       	TestIntegration/TestKongPluginInstallationEssentials

Which issue this PR fixes

Fixes #

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect significant changes

@pmalek pmalek added this to the KGO v1.4.x milestone Oct 4, 2024
@pmalek pmalek self-assigned this Oct 4, 2024
@pmalek pmalek changed the title tests: fix HTTPRoute update in integration test tests: fix HTTPRoute update in KongPluginInstallation integration test Oct 4, 2024
@pmalek pmalek marked this pull request as ready for review October 4, 2024 13:14
@pmalek pmalek requested a review from a team as a code owner October 4, 2024 13:14
czeslavo
czeslavo approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@czeslavo czeslavo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pmalek pmalek force-pushed the fix-kpi-integration-test-update branch from 0f9048d to 4d446a6 Compare October 4, 2024 13:39
@pmalek pmalek enabled auto-merge (squash) October 4, 2024 13:39
@pmalek pmalek merged commit 0522a4b into main Oct 4, 2024
21 checks passed
@pmalek pmalek deleted the fix-kpi-integration-test-update branch October 4, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czeslavo czeslavo czeslavo approved these changes

Assignees

@pmalek pmalek

Labels
area/tests test-flake
Projects
None yet
Milestone
KGO v1.4.x
Development

Successfully merging this pull request may close these issues.
2 participants
@pmalek @czeslavo