Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: fix ControlPlane update in integration test #696

Merged
merged 1 commit into from
Oct 4, 2024
Merged

tests: fix ControlPlane update in integration test #696

merged 1 commit into from
Oct 4, 2024

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented Oct 4, 2024

What this PR does / why we need it:

This aims to fix the following failure in integration tests suite: https://github.com/Kong/gateway-operator/actions/runs/11176508266/job/31070023471?pr=689#step:5:5407

    test_controlplane.go:619: 
        	Error Trace:	/home/runner/work/gateway-operator/gateway-operator/test/integration/test_controlplane.go:619
        	Error:      	Received unexpected error:
        	            	Operation cannot be fulfilled on controlplanes.gateway-operator.konghq.com "6902cf03-faee-42ed-a770-f28ca1ef448a": the object has been modified; please apply your changes to the latest version and try again
        	Test:       	TestIntegration/TestControlPlaneUpdate
    setup.go:54: TestIntegration/TestControlPlaneUpdate failed, dumped diagnostics to /tmp/ktf-diag-3426582018

@pmalek pmalek added this to the KGO v1.4.x milestone Oct 4, 2024
@pmalek pmalek self-assigned this Oct 4, 2024
@pmalek pmalek force-pushed the fix-controlplane-update-integration-test branch 2 times, most recently from f977b9b to c883690 Compare October 4, 2024 12:12
@pmalek pmalek force-pushed the fix-controlplane-update-integration-test branch from c883690 to 9461761 Compare October 4, 2024 13:18
@pmalek pmalek marked this pull request as ready for review October 4, 2024 13:19
@pmalek pmalek requested a review from a team as a code owner October 4, 2024 13:19
@pmalek pmalek enabled auto-merge (squash) October 4, 2024 13:22
@pmalek pmalek merged commit 67a3ef9 into main Oct 4, 2024
21 checks passed
@pmalek pmalek deleted the fix-controlplane-update-integration-test branch October 4, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czeslavo czeslavo czeslavo approved these changes

Assignees

@pmalek pmalek

Labels
area/tests test-flake
Projects
None yet
Milestone
KGO v1.4.x
Development

Successfully merging this pull request may close these issues.
2 participants
@pmalek @czeslavo