tests: fix data race in KongConsumer data race tests #692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czeslavo
approved these changes
Oct 3, 2024
There was a problem hiding this comment.
Reproduced this in a minimal example, looks like a legit fix 🤞
func TestSomething(t *testing.T) {
c := &configurationv1.KongConsumer{
CustomID: "custom-id",
}
ctx, _ := context.WithTimeout(context.Background(), 10*time.Second)
go func() {
for {
select {
case <-ctx.Done():
return
default:
c.CustomID = "changed-id"
}
}
}()
go func() {
for {
select {
case <-ctx.Done():
return
default:
ci := sdkkonnectcomp.ConsumerInput{
CustomID: &c.CustomID,
}
_ = *ci.GetCustomID()
}
}
}()
}
pmalek
force-pushed
the
fix-datarace-in-kongconsumer-envtest
branch
from
928d5d2 to
5ac8235
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
An attempt at solving the data race in
KongConsumerenvtest suite.Example: https://github.com/Kong/gateway-operator/actions/runs/11162590333/job/31027578476?pr=687#step:5:440
Possibly fixes #655