-
Notifications
You must be signed in to change notification settings - Fork 14
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
tests: add Konnect entities integration test (#537)
* tests: add Konnect entities integration test * address review comments
- Loading branch information
Showing
13 changed files
with
173 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,134 @@ | ||
| package integration | ||
|
|
||
| import ( | ||
| "testing" | ||
| "time" | ||
|
|
||
| "github.com/Kong/sdk-konnect-go/models/components" | ||
| "github.com/google/uuid" | ||
| "github.com/samber/lo" | ||
| "github.com/stretchr/testify/assert" | ||
| "github.com/stretchr/testify/require" | ||
| k8serrors "k8s.io/apimachinery/pkg/api/errors" | ||
| metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
| "k8s.io/apimachinery/pkg/types" | ||
| "sigs.k8s.io/controller-runtime/pkg/client" | ||
|
|
||
| testutils "github.com/kong/gateway-operator/pkg/utils/test" | ||
| "github.com/kong/gateway-operator/test" | ||
| "github.com/kong/gateway-operator/test/helpers" | ||
|
|
||
| configurationv1alpha1 "github.com/kong/kubernetes-configuration/api/configuration/v1alpha1" | ||
| konnectv1alpha1 "github.com/kong/kubernetes-configuration/api/konnect/v1alpha1" | ||
| ) | ||
|
|
||
| func TestKonnectEntities(t *testing.T) { | ||
| // A cleaner is created underneath anyway, and a whole namespace is deleted eventually. | ||
| // We can't use a cleaner to delete objects because it handles deletes in FIFO order and that won't work in this | ||
| // case: KonnectAPIAuthConfiguration shouldn't be deleted before any other object as that is required for others to | ||
| // complete their finalizer which is deleting a reflecting entity in Konnect. That's why we're only cleaning up a | ||
| // KonnectControlPlane and waiting for its deletion synchronously with deleteObjectAndWaitForDeletionFn to ensure it | ||
| // was successfully deleted along with its children. The KonnectAPIAuthConfiguration is implicitly deleted along | ||
| // with the namespace. | ||
| ns, _ := helpers.SetupTestEnv(t, GetCtx(), GetEnv()) | ||
|
|
||
| // Let's generate a unique test ID that we can refer to in Konnect entities. | ||
| // Using only the first 8 characters of the UUID to keep the ID short enough for Konnect to accept it as a part | ||
| // of an entity name. | ||
| testID := uuid.NewString()[:8] | ||
| t.Logf("Running Konnect entities test with ID: %s", testID) | ||
|
|
||
| t.Logf("Creating KonnectAPIAuthConfiguration") | ||
| authCfg := &konnectv1alpha1.KonnectAPIAuthConfiguration{ | ||
| ObjectMeta: metav1.ObjectMeta{ | ||
| Name: "auth-" + testID, | ||
| Namespace: ns.Name, | ||
| }, | ||
| Spec: konnectv1alpha1.KonnectAPIAuthConfigurationSpec{ | ||
| Type: konnectv1alpha1.KonnectAPIAuthTypeToken, | ||
| Token: test.KonnectAccessToken(), | ||
| ServerURL: test.KonnectServerURL(), | ||
| }, | ||
| } | ||
| err := GetClients().MgrClient.Create(GetCtx(), authCfg) | ||
| require.NoError(t, err) | ||
|
|
||
| cpName := "cp-" + testID | ||
| t.Logf("Creating KonnectControlPlane %s", cpName) | ||
| cp := &konnectv1alpha1.KonnectControlPlane{ | ||
| ObjectMeta: metav1.ObjectMeta{ | ||
| Name: cpName, | ||
| Namespace: ns.Name, | ||
| }, | ||
| Spec: konnectv1alpha1.KonnectControlPlaneSpec{ | ||
| CreateControlPlaneRequest: components.CreateControlPlaneRequest{ | ||
| Name: cpName, | ||
| ClusterType: lo.ToPtr(components.ClusterTypeClusterTypeControlPlane), | ||
| Labels: map[string]string{"test_id": testID}, | ||
| }, | ||
| KonnectConfiguration: konnectv1alpha1.KonnectConfiguration{ | ||
| APIAuthConfigurationRef: konnectv1alpha1.KonnectAPIAuthConfigurationRef{ | ||
| Name: authCfg.Name, | ||
| }, | ||
| }, | ||
| }, | ||
| } | ||
| err = GetClients().MgrClient.Create(GetCtx(), cp) | ||
| require.NoError(t, err) | ||
| t.Cleanup(deleteObjectAndWaitForDeletionFn(t, cp)) | ||
|
|
||
| t.Logf("Waiting for Konnect ID to be assigned to ControlPlane %s/%s", cp.Namespace, cp.Name) | ||
| require.EventuallyWithT(t, func(t *assert.CollectT) { | ||
| err := GetClients().MgrClient.Get(GetCtx(), types.NamespacedName{Name: cp.Name, Namespace: cp.Namespace}, cp) | ||
| require.NoError(t, err) | ||
| assert.NotEmpty(t, cp.Status.KonnectEntityStatus.GetKonnectID()) | ||
| assert.NotEmpty(t, cp.Status.KonnectEntityStatus.GetOrgID()) | ||
| assert.NotEmpty(t, cp.Status.KonnectEntityStatus.GetServerURL()) | ||
| }, testutils.ObjectUpdateTimeout, time.Second) | ||
|
|
||
| t.Logf("Creating KongService") | ||
| ksName := "ks-" + testID | ||
| ks := &configurationv1alpha1.KongService{ | ||
| ObjectMeta: metav1.ObjectMeta{ | ||
| Name: "ks-" + testID, | ||
| Namespace: ns.Name, | ||
| }, | ||
| Spec: configurationv1alpha1.KongServiceSpec{ | ||
| ControlPlaneRef: &configurationv1alpha1.ControlPlaneRef{ | ||
| Type: configurationv1alpha1.ControlPlaneRefKonnectNamespacedRef, | ||
| KonnectNamespacedRef: &configurationv1alpha1.KonnectNamespacedRef{Name: cp.Name}, | ||
| }, | ||
| KongServiceAPISpec: configurationv1alpha1.KongServiceAPISpec{ | ||
| Name: lo.ToPtr(ksName), | ||
| URL: lo.ToPtr("http://example.com"), | ||
| }, | ||
| }, | ||
| } | ||
| err = GetClients().MgrClient.Create(GetCtx(), ks) | ||
| require.NoError(t, err) | ||
|
|
||
| t.Logf("Waiting for KongService to be updated with Konnect ID") | ||
| require.EventuallyWithT(t, func(t *assert.CollectT) { | ||
| err := GetClients().MgrClient.Get(GetCtx(), types.NamespacedName{Name: ks.Name, Namespace: ks.Namespace}, ks) | ||
| require.NoError(t, err) | ||
| assert.NotEmpty(t, ks.Status.Konnect.KonnectEntityStatus.GetKonnectID()) | ||
| assert.NotEmpty(t, ks.Status.Konnect.KonnectEntityStatus.GetOrgID()) | ||
| assert.NotEmpty(t, ks.Status.Konnect.KonnectEntityStatus.GetServerURL()) | ||
| }, testutils.ObjectUpdateTimeout, time.Second) | ||
|
|
||
| // TODO(czeslavo): test all supported entities here | ||
| } | ||
|
|
||
| // deleteObjectAndWaitForDeletionFn returns a function that deletes the given object and waits for it to be gone. | ||
| // It's designed to be used with t.Cleanup() to ensure the object is properly deleted (it's not stuck with finalizers, etc.). | ||
| func deleteObjectAndWaitForDeletionFn(t *testing.T, obj client.Object) func() { | ||
| return func() { | ||
| err := GetClients().MgrClient.Delete(GetCtx(), obj) | ||
| require.NoError(t, err) | ||
|
|
||
| require.EventuallyWithT(t, func(t *assert.CollectT) { | ||
| err := GetClients().MgrClient.Get(GetCtx(), types.NamespacedName{Name: obj.GetName(), Namespace: obj.GetNamespace()}, obj) | ||
| assert.True(t, k8serrors.IsNotFound(err)) | ||
| }, testutils.ObjectUpdateTimeout, time.Second) | ||
| } | ||
| } |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.