chore(linter): enable all go-vet rules (#867)

Kong · Nov 18, 2024 · 5929ab4 · 5929ab4
1 parent 3de5b0a
commit 5929ab4
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/.golangci.yaml b/.golangci.yaml
@@ -40,6 +40,11 @@ linters-settings:
       - default
       - prefix(github.com/kong/kubernetes-configuration)
       - prefix(github.com/kong/gateway-operator)
+  govet:
+    enable-all: true # To have checks like e.g. unusedwrite.
+    disable:
+      - fieldalignment
+      - shadow
   importas:
     no-unaliased: true
     alias:

diff --git a/controller/dataplane/owned_deployment.go b/controller/dataplane/owned_deployment.go
@@ -331,7 +331,7 @@ func reconcileDataPlaneDeployment(
 			// the replicas to the minReplicas if the existing Deployment replicas
 			// are less than the minReplicas to enforce faster scaling before HPA
 			// kicks in.
-			(scaling != nil && scaling.HorizontalScaling != nil &&
+			(scaling.HorizontalScaling != nil &&
 				scaling.HorizontalScaling.MinReplicas != nil &&
 				existing.Spec.Replicas != nil &&
 				*existing.Spec.Replicas < *scaling.HorizontalScaling.MinReplicas) {