Refactor/client error handling and incorporate latest Sia consensus changes #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add Hash256 doc comment
remove `HelperError` in favor of individual error enums for each helper. Previous design made it extremely difficult to do clean error handling in case one helper called another.
renames wasm::Client -> wasm::WasmClient
…KDF module - ie, each logic path is represented verbosely with a unique error variant
…lly commited while prototyping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generalizes the error handling of ApiClient trait. The newly introduced WasmClientError and NativeClientError types follow the same pattern as Sia errors within KDF. They are purposefully verbose to allow each variant to represent a unique logical path.
Simplifies ApiClient trait by consolidating methods.
Incorporates changes to Sia consensus from:
SiaFoundation/core#224
SiaFoundation/core#220