Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(build_transformer): npm error when building without package.json #3

Merged
merged 4 commits into from
Sep 24, 2024
Merged

fix(build_transformer): npm error when building without package.json #3

merged 4 commits into from
Sep 24, 2024

Conversation

takenagain
Copy link
Collaborator

@takenagain takenagain commented Sep 23, 2024 •
edited
Loading

Changes:

  • Check if package.json exists before running npm commands. This is to support the old project structure that relies on npm and webpack.
  • Overwrite existing files when extracting zips: to prevent build errors when migrating from the old KW build transformer to this one in an existing project

@takenagain
Fix defi sdk example build
19bb329 
Support projects that require npm (komodo-wallet) and newer projects that don't (no package.json present)
@takenagain
Overwrite existing files when extracting zips
e296b1b
@takenagain
Add code validation and unit test workflows for PRs
526e17d
@takenagain takenagain added the bug Something isn't working label Sep 23, 2024
@takenagain takenagain self-assigned this Sep 23, 2024
@CharlVS CharlVS merged commit ff6bc83 into dev Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CharlVS CharlVS CharlVS approved these changes

Assignees

@takenagain takenagain

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@takenagain @CharlVS