Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updates vrsc to v1.1.1-1 (upd) #520

Merged
merged 2 commits into from
Sep 7, 2023
Merged

updates vrsc to v1.1.1-1 (upd) #520

merged 2 commits into from
Sep 7, 2023

Conversation

gcharang
Copy link
Collaborator

@gcharang gcharang commented Aug 31, 2023 •
edited
Loading

Issue raised: #519
PR to the docker repo: smk762/notary_docker_3p#45
diff: VerusCoin/VerusCoin@2d32721...2eb2238

Updated info for v1.1.1-1:

DeckerSU
DeckerSU previously approved these changes Aug 31, 2023
View reviewed changes
smk762
smk762 previously approved these changes Sep 1, 2023
View reviewed changes
ca333
ca333 previously approved these changes Sep 2, 2023
View reviewed changes
Copy link
Contributor

@ca333 ca333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sec code reviewed

@TheComputerGenie
Copy link
Contributor

https://discord.com/channels/444621794964537354/449633429198340106/1147345315389767751

@gcharang gcharang marked this pull request as draft September 3, 2023 07:23
@gcharang gcharang dismissed stale reviews from ca333, smk762, and DeckerSU via ce65eeb September 4, 2023 12:03
@gcharang gcharang changed the title updates vrsc to v1.1.1 updates vrsc to v1.1.1-1 (upd) Sep 4, 2023
@gcharang gcharang marked this pull request as ready for review September 4, 2023 12:05
DeckerSU
DeckerSU approved these changes Sep 4, 2023
View reviewed changes
Copy link
Contributor

@DeckerSU DeckerSU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a security review standpoint, LGTM.

@Alrighttt
Copy link
Member

LGTM, no obvious memory errors or malicious inclusions.

Just one question, why did they change the zlib download path to github? The newer version is also available at https://www.zlib.net/

Alrighttt
Alrighttt approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@Alrighttt Alrighttt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CHMEX
Copy link
Contributor

CHMEX commented Sep 7, 2023 via email

ca333
ca333 approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@ca333 ca333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sec review complete

@gcharang gcharang merged commit c32a871 into KomodoPlatform:dev Sep 7, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alrighttt Alrighttt Alrighttt approved these changes

@smk762 smk762 smk762 approved these changes

@DeckerSU DeckerSU DeckerSU approved these changes

@ca333 ca333 ca333 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@gcharang @TheComputerGenie @Alrighttt @CHMEX @ca333 @DeckerSU @smk762