Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undefined electrumServers #206

Closed
wants to merge 1 commit into from

Conversation

sawlysawly
Copy link

Fixes #205

@pbca26
Copy link

pbca26 commented Jan 27, 2019

unfortunately we already had quite a handful of issues with global
it's better to use ipc for any large collections of static data

please don't submit PR to master branch
the process is dev -> master

@pbca26 pbca26 closed this Jan 27, 2019
@sawlysawly
Copy link
Author

ok I will submit to dev for more PR in future thanks

for this issue #205 it still needs to be fixed

this PR is fixes the issue but i agreed its not good to add lots of stuff to global

I think then the issue is in util/mainWindow.js. it refers to the global value but it doesnt exists

@pbca26 can you refer to #205 for more informations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants