-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Corrected path for printer.cfg #6736
base: master
Are you sure you want to change the base?
Conversation
Thank you for submitting a PR, please be aware that you need to sign off to accept the developer certificate of origin, please see point 3 in https://github.com/Klipper3d/klipper/blob/master/docs/CONTRIBUTING.md#what-to-expect-in-a-review You also have a whitespace issue you need to clear up, so the build checks can pass. Thanks |
Signed-off-by: Christian Navolskyi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for signing off, please see my one comment.
James
docs/Installation.md
Outdated
named "printer.cfg" in the home directory of the pi user | ||
(ie, /home/pi/printer.cfg). | ||
named "printer.cfg" under `~/printer_data/config` | ||
(ie, /home/pi/printer_data/config/printer.cfg). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably best to word it so that the user knows that pi may not be the username.
Something i should have implied the first time round really!
Thanks
James
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. Pushed an update.
Signed-off-by: Christian Navolskyi <[email protected]>
Looks like the path for
printer.cfg
changed a while ago according to this forum post.