Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gcode_move.py #6467

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

CooperGerman
Copy link

Updated gcode save and restore commands in order to stack up states until a max is reached and pop those states when restore commands are called.

This allows for macros to be called recursively without overwriting the previously saved state. (in my case using klipper-macros from https://github.com/jschuh/klipper-macros with modified ercf_software.cfg from https://github.com/EtteGit/EnragedRabbitProject)

Updated gcode save and restore commands in order to stack up states until a max is reached and pop those states when restore commands are called.

This allows for macros to be called recursively without overwriting the previously saved state.  (in my case using klipper-macros from [url]https://github.com/jschuh/klipper-macros with modified ercf_software.cfg )
@CooperGerman
Copy link
Author

Hi, i see that the builtin commands.test fails on restoring twice the 'default' gcode state.
My understanding is that the way it normally works is that you can restore a previously saved state mutliple times as the restore_gcode code does not remove it when beeing restored.

In my version this no longer is possible... What expected behavior should the save/restore commands have ?
Is my proposition coherent with what klipper wants to be doing ?

Copy link

github-actions bot commented Feb 8, 2024

Thank you for your contribution to Klipper. Unfortunately, a reviewer has not assigned themselves to this GitHub Pull Request. All Pull Requests are reviewed before merging, and a reviewer will need to volunteer. Further information is available at: https://www.klipper3d.org/CONTRIBUTING.html

There are some steps that you can take now:

  1. Perform a self-review of your Pull Request by following the steps at: https://www.klipper3d.org/CONTRIBUTING.html#what-to-expect-in-a-review
    If you have completed a self-review, be sure to state the results of that self-review explicitly in the Pull Request comments. A reviewer is more likely to participate if the bulk of a review has already been completed.
  2. Consider opening a topic on the Klipper Discourse server to discuss this work. The Discourse server is a good place to discuss development ideas and to engage users interested in testing. Reviewers are more likely to prioritize Pull Requests with an active community of users.
  3. Consider helping out reviewers by reviewing other Klipper Pull Requests. Taking the time to perform a careful and detailed review of others work is appreciated. Regular contributors are more likely to prioritize the contributions of other regular contributors.

Unfortunately, if a reviewer does not assign themselves to this GitHub Pull Request then it will be automatically closed. If this happens, then it is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available.

Best regards,
~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant