-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update gcode_move.py #6467
base: master
Are you sure you want to change the base?
Update gcode_move.py #6467
Conversation
Updated gcode save and restore commands in order to stack up states until a max is reached and pop those states when restore commands are called. This allows for macros to be called recursively without overwriting the previously saved state. (in my case using klipper-macros from [url]https://github.com/jschuh/klipper-macros with modified ercf_software.cfg )
Hi, i see that the builtin commands.test fails on restoring twice the 'default' gcode state. In my version this no longer is possible... What expected behavior should the save/restore commands have ? |
Thank you for your contribution to Klipper. Unfortunately, a reviewer has not assigned themselves to this GitHub Pull Request. All Pull Requests are reviewed before merging, and a reviewer will need to volunteer. Further information is available at: https://www.klipper3d.org/CONTRIBUTING.html There are some steps that you can take now:
Unfortunately, if a reviewer does not assign themselves to this GitHub Pull Request then it will be automatically closed. If this happens, then it is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available. Best regards, PS: I'm just an automated script, not a human being. |
Updated gcode save and restore commands in order to stack up states until a max is reached and pop those states when restore commands are called.
This allows for macros to be called recursively without overwriting the previously saved state. (in my case using klipper-macros from https://github.com/jschuh/klipper-macros with modified ercf_software.cfg from https://github.com/EtteGit/EnragedRabbitProject)