Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

idex_modes: Fixed the case when carriages home in the same direction #6310

Merged
merged 5 commits into from
Sep 29, 2023
Merged

idex_modes: Fixed the case when carriages home in the same direction #6310

merged 5 commits into from
Sep 29, 2023

Commits on Aug 26, 2023

  1. idex_modes: Fixed the case when carriages home in the same direction 

    Previous version of the code assumed that dual carriages home away
from each other, which is not true on some machines, which have the
second dual carriage homing on the first carriage. The new code
correctly identifies the relative order of the carriages now.

Signed-off-by: Dmitry Butyugin <[email protected]>
    @dmbutyugin
    dmbutyugin committed Aug 26, 2023
    Configuration menu
    Copy the full SHA
    b067620 View commit details
    Browse the repository at this point in the history

  2. idex_modes: Disable carriages proximity checks when safe_distance == 0 

    This fixes discrepancies between the documentation and the actual
implementation of the carriages kinematic ranges calculation.

Signed-off-by: Dmitry Butyugin <[email protected]>
    @dmbutyugin
    dmbutyugin committed Aug 26, 2023
    Configuration menu
    Copy the full SHA
    52bada4 View commit details
    Browse the repository at this point in the history

  3. docs: Notes about dual_carriage homing and proximity checks changes 

    Signed-off-by: Dmitry Butyugin <[email protected]>
    @dmbutyugin
    dmbutyugin committed Aug 26, 2023
    Configuration menu
    Copy the full SHA
    d7c6fe1 View commit details
    Browse the repository at this point in the history

  4. idex_modes: Fixed clearing of homing state after homing in certain modes 

    In case of multi-MCU homing it is possible that the carriage position
will end up outside of the allowed motion range due to latencies in data
transmission between MCUs. Selecting certain modes after homing could
result in home state clearing instead of blocking the motion of the
active carriage. This commit fixes this undesired behavior.

Signed-off-by: Dmitry Butyugin <[email protected]>
    @dmbutyugin
    dmbutyugin committed Aug 26, 2023
    Configuration menu
    Copy the full SHA
    ded3f90 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2023

  1. idex_modes: Updated the code and comments for homing fix 

    A more readable version of ded3f90
    @dmbutyugin
    dmbutyugin authored Sep 29, 2023
    Configuration menu
    Copy the full SHA
    36116eb View commit details
    Browse the repository at this point in the history