Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts: Support both H743 and H723 BTT SKR3 boards sdflash #6301

Merged
merged 2 commits into from
Aug 12, 2023

Conversation

dewhisna
Copy link
Contributor

BigTreeTech is shipping the SKR-3 Controller Board now with the STM32H723 micro in addition to the existing STM32H743 version.

This adds the H723 target to the spi-flash script and renames the existing H743 variant to be consistent with other entries and disambiguate between the two.

@github-actions
Copy link

github-actions bot commented Aug 8, 2023

Thank you for your contribution to Klipper. Unfortunately, a reviewer has not assigned themselves to this GitHub Pull Request. All Pull Requests are reviewed before merging, and a reviewer will need to volunteer. Further information is available at: https://www.klipper3d.org/CONTRIBUTING.html

There are some steps that you can take now:

  1. Perform a self-review of your Pull Request by following the steps at: https://www.klipper3d.org/CONTRIBUTING.html#what-to-expect-in-a-review
    If you have completed a self-review, be sure to state the results of that self-review explicitly in the Pull Request comments. A reviewer is more likely to participate if the bulk of a review has already been completed.
  2. Consider opening a topic on the Klipper Discourse server to discuss this work. The Discourse server is a good place to discuss development ideas and to engage users interested in testing. Reviewers are more likely to prioritize Pull Requests with an active community of users.
  3. Consider helping out reviewers by reviewing other Klipper Pull Requests. Taking the time to perform a careful and detailed review of others work is appreciated. Regular contributors are more likely to prioritize the contributions of other regular contributors.

Unfortunately, if a reviewer does not assign themselves to this GitHub Pull Request then it will be automatically closed. If this happens, then it is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available.

Best regards,
~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.

@KevinOConnor
Copy link
Collaborator

Thanks. It's hard for me to review changes to board_defs.py - maybe @JamesH1978 or @Arksine could provide some comments.

-Kevin

@JamesH1978
Copy link
Collaborator

It's exactly the same pin out for both, so i would suggest using an alias to the original(renamed), rather than a whole new section.

Thanks
James

@dewhisna
Copy link
Contributor Author

dewhisna commented Aug 9, 2023

But it's NOT an alias... It's a different microprocessor and has a different microprocessor value. And no other entry has the H723. So there's nothing it's an alias of.

The only way to be an alias would be if the microprocessor type is useless in this script, in which case, it should be removed from all of the entries and many more become aliases.

@JamesH1978
Copy link
Collaborator

Apologies, i see what you mean, wasnt taking the different processors into account. @Arksine would have to comment on where the mcu is used, if anywhere on a SDIO connection

@Arksine
Copy link
Collaborator

Arksine commented Aug 10, 2023

Overall the PR looks good to me with one sticking point...changing the name from btt-skr-3 to btt-skr-3-h743 will break update workflows for existing owners of the SKR3, they will get an error when they attempt to update using btt-skr-3. If we make that change I think it needs to be noted in config_changes.md.

@dewhisna
Copy link
Contributor Author

Fair enough. I added an entry in Config_Changes.md as requested, with text phrased similar to changes like this one. And I rebased this PR to prevent a merge conflict on that file.

Thanks for clarifying how that should be documented. I wasn't sure how that was handled and only knew that leaving the original entry unchanged was even more confusing to end-users as it required a priori knowledge that the original SKR3 was the H743.

@Arksine
Copy link
Collaborator

Arksine commented Aug 11, 2023

Looks good to me. Thanks.

@KevinOConnor KevinOConnor merged commit 00b78c6 into Klipper3d:master Aug 12, 2023
1 check passed
@KevinOConnor
Copy link
Collaborator

Thanks.

-Kevin

@locki-cz
Copy link
Contributor

@dewhisna can you add also alias for Octopus board? #6306

@github-actions github-actions bot locked and limited conversation to collaborators Aug 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants