-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scripts: Support both H743 and H723 BTT SKR3 boards sdflash #6301
Conversation
Thank you for your contribution to Klipper. Unfortunately, a reviewer has not assigned themselves to this GitHub Pull Request. All Pull Requests are reviewed before merging, and a reviewer will need to volunteer. Further information is available at: https://www.klipper3d.org/CONTRIBUTING.html There are some steps that you can take now:
Unfortunately, if a reviewer does not assign themselves to this GitHub Pull Request then it will be automatically closed. If this happens, then it is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available. Best regards, PS: I'm just an automated script, not a human being. |
Thanks. It's hard for me to review changes to board_defs.py - maybe @JamesH1978 or @Arksine could provide some comments. -Kevin |
It's exactly the same pin out for both, so i would suggest using an alias to the original(renamed), rather than a whole new section. Thanks |
But it's NOT an alias... It's a different microprocessor and has a different microprocessor value. And no other entry has the H723. So there's nothing it's an alias of. The only way to be an alias would be if the microprocessor type is useless in this script, in which case, it should be removed from all of the entries and many more become aliases. |
Apologies, i see what you mean, wasnt taking the different processors into account. @Arksine would have to comment on where the mcu is used, if anywhere on a SDIO connection |
Overall the PR looks good to me with one sticking point...changing the name from |
Signed-off-by: Donna Whisnant <[email protected]>
Signed-off-by: Donna Whisnant <[email protected]>
Fair enough. I added an entry in Thanks for clarifying how that should be documented. I wasn't sure how that was handled and only knew that leaving the original entry unchanged was even more confusing to end-users as it required a priori knowledge that the original SKR3 was the H743. |
Looks good to me. Thanks. |
Thanks. -Kevin |
BigTreeTech is shipping the SKR-3 Controller Board now with the STM32H723 micro in addition to the existing STM32H743 version.
This adds the H723 target to the spi-flash script and renames the existing H743 variant to be consistent with other entries and disambiguate between the two.