Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config for printer Creality CR10s Pro V2 #6300

Conversation

flatline-84
Copy link
Contributor

Created a base config for the Creality CR10s Pro v2 as described here: https://www.creality.com/products/cr-10s-pro-v2-3d-printer

This will allow users with this printer to more easily setup Klipper firmware.

Created a base config for the Creality CR10s Pro v2 as described here: https://www.creality.com/products/cr-10s-pro-v2-3d-printer

This will allow users with this printer to more easily setup Klipper firmware.
@JamesH1978
Copy link
Collaborator

Thankyou for submitting a PR, please could you refer to point 3 in the "what to expect" section in https://github.com/Klipper3d/klipper/blob/master/docs/CONTRIBUTING.md and add a signed-off-by line and point 4 in https://github.com/Klipper3d/klipper/blob/master/docs/Example_Configs.md and include the regression tests.

Thanks
James

A default configuration file for the Creality CR10s Pro v2 Printer.

Signed-off-by: Peter Kydas <[email protected]>
@flatline-84
Copy link
Contributor Author

Hi James, I have addressed all the points. Hope this is correct

Copy link
Collaborator

@JamesH1978 JamesH1978 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the changes i asked, please see my comments.

Thanks
James

config/printer-creality-cr10s-pro-v2-2020.cfg Outdated Show resolved Hide resolved
config/printer-creality-cr10s-pro-v2-2020.cfg Show resolved Hide resolved
config/printer-creality-cr10s-pro-v2-2020.cfg Show resolved Hide resolved
Copy link
Collaborator

@JamesH1978 JamesH1978 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

Thanks
James

@KevinOConnor
Copy link
Collaborator

Thanks. Could you also update the pid lines to use option: value syntax instead of option = value syntax? https://www.klipper3d.org/Example_Configs.html point 7d.

-Kevin

@flatline-84
Copy link
Contributor Author

Good catch Kevin. Thanks, updated now

Copy link
Collaborator

@JamesH1978 JamesH1978 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for missing the syntax,

Still looks good

Thanks
James

@KevinOConnor
Copy link
Collaborator

Alas, the option = value is still present in the heater_bed section.

Cheers,
-Kevin

@flatline-84
Copy link
Contributor Author

I could have sworn I did a find + replace but apparently not. Should be properly good to go now

@KevinOConnor KevinOConnor merged commit 15c3824 into Klipper3d:master Aug 13, 2023
1 check passed
@KevinOConnor
Copy link
Collaborator

Thanks.

-Kevin

4rianton pushed a commit to 4rianton/klipper that referenced this pull request Aug 18, 2023
Created a base config for the Creality CR10s Pro v2 as described here: https://www.creality.com/products/cr-10s-pro-v2-3d-printer

This will allow users with this printer to more easily setup Klipper firmware.

Signed-off-by: Peter Kydas <[email protected]>
rogerlz referenced this pull request in DangerKlippers/danger-klipper Dec 19, 2023
Created a base config for the Creality CR10s Pro v2 as described here: https://www.creality.com/products/cr-10s-pro-v2-3d-printer

This will allow users with this printer to more easily setup Klipper firmware.

Signed-off-by: Peter Kydas <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Aug 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants