-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add config for printer Creality CR10s Pro V2 #6300
Add config for printer Creality CR10s Pro V2 #6300
Conversation
Created a base config for the Creality CR10s Pro v2 as described here: https://www.creality.com/products/cr-10s-pro-v2-3d-printer This will allow users with this printer to more easily setup Klipper firmware.
Thankyou for submitting a PR, please could you refer to point 3 in the "what to expect" section in https://github.com/Klipper3d/klipper/blob/master/docs/CONTRIBUTING.md and add a signed-off-by line and point 4 in https://github.com/Klipper3d/klipper/blob/master/docs/Example_Configs.md and include the regression tests. Thanks |
A default configuration file for the Creality CR10s Pro v2 Printer. Signed-off-by: Peter Kydas <[email protected]>
Hi James, I have addressed all the points. Hope this is correct |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for making the changes i asked, please see my comments.
Thanks
James
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me.
Thanks
James
Thanks. Could you also update the pid lines to use -Kevin |
Good catch Kevin. Thanks, updated now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for missing the syntax,
Still looks good
Thanks
James
Alas, the Cheers, |
I could have sworn I did a find + replace but apparently not. Should be properly good to go now |
Thanks. -Kevin |
Created a base config for the Creality CR10s Pro v2 as described here: https://www.creality.com/products/cr-10s-pro-v2-3d-printer This will allow users with this printer to more easily setup Klipper firmware. Signed-off-by: Peter Kydas <[email protected]>
Created a base config for the Creality CR10s Pro v2 as described here: https://www.creality.com/products/cr-10s-pro-v2-3d-printer This will allow users with this printer to more easily setup Klipper firmware. Signed-off-by: Peter Kydas <[email protected]>
Created a base config for the Creality CR10s Pro v2 as described here: https://www.creality.com/products/cr-10s-pro-v2-3d-printer
This will allow users with this printer to more easily setup Klipper firmware.