delayed_gcode: make UPDATE_DELAYED_GCODE safe for klippy:ready handlers

When another klippy:ready handler executes UPDATE_DELAYED_GCODE before DelayedGcode's ready handler runs, then self.timer_handler is None, causing update_timer() to fail. Signed-off-by: Rolf Schäuble <[email protected]>
Klipper3d · Jun 29, 2024 · c8ec9d2 · c8ec9d2
1 parent 4d21ffc
commit c8ec9d2
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/klippy/extras/delayed_gcode.py b/klippy/extras/delayed_gcode.py
@@ -48,7 +48,11 @@ def cmd_UPDATE_DELAYED_GCODE(self, gcmd):
             waketime = self.reactor.NEVER
             if self.duration:
                 waketime = self.reactor.monotonic() + self.duration
-            self.reactor.update_timer(self.timer_handler, waketime)
+
+            # Update the timer if it has already been created. A klippy:ready
+            # handler might call this method before that happened.
+            if self.timer_handler is not None:
+              self.reactor.update_timer(self.timer_handler, waketime)
 
 def load_config_prefix(config):
     return DelayedGcode(config)