An easy way to access cookies in RestResponse #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RudraniW
force-pushed
the
restResponseCookies
branch
from
d589cca
to
8b236e7
Compare
pushkarnk
reviewed
Jul 10, 2019
| @@ -327,6 +327,23 @@ public class RestRequest: NSObject { | |||
| task.resume() | |||
| } | |||
| } | |||
| private func getCookies(from response: HTTPURLResponse?) -> [HTTPCookie]? { | |||
| guard let headers = response?.allHeaderFields else{ | |||
pushkarnk
reviewed
Jul 10, 2019
| var headerFields = [String : String]() | ||
| for (key, value) in headers{ | ||
| guard let key = key as? String, let value = value as? String else{ | ||
| continue } |
pushkarnk
reviewed
Jul 10, 2019
| let number = request.parameters["number"].map { Int($0) ?? 0 } ?? 0 | ||
| for no in 0..<number { | ||
| var cookieProps: [HTTPCookiePropertyKey: Any] | ||
| cookieProps = [ |
RudraniW
force-pushed
the
restResponseCookies
branch
2 times, most recently
from
a7dee31
to
6f3a02a
Compare
djones6
reviewed
Jul 15, 2019
| #if canImport(FoundationNetworking) | ||
| import FoundationNetworking | ||
| #endif | ||
| #endif |
There was a problem hiding this comment.
Isn't this block already present below?
(this might be a merge issue with #67)
djones6
approved these changes
Jul 17, 2019
|
@RudraniW @pushkarnk is this ready to merge? |
pushkarnk
approved these changes
Jul 19, 2019
|
@djones6 yes, I think we can merge |
added 8 commits
August 14, 2019 14:36
RudraniW
force-pushed
the
restResponseCookies
branch
from
a9ebc0e
to
c7ef508
Compare
|
CI is failing due to unrelated problem with Swift 5.1 (see #72) - so I'm going to merge this. |
djones6
added a commit
that referenced
this pull request
Sep 10, 2019
djones6
added a commit
that referenced
this pull request
Sep 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, cookies are sent as a part
HTTPURLResponseheaders. To access cookies, they have to be fished out of these headers. ThegetCookies(from: )function takesHTTPURLResponseand returns HTTPCookie(s). New public propertycookiesis added intoRestResponsestructure. Cookies return by getCookies(from: )are added intocookies. The cookies can be accessed by accessing 'cookiesproperty ofRestResponse.