Use the neutral cultures zh-Hans and zh-Hant #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: Refer to dotnet/msbuild#3897 When building with dotnet cli, certain cultures cannot be utilized for resource localization, such as getting localized strings. This impacts both the build process (e.g., identifying and processing resource files) and the lookup of resources at runtime. For example: MyStrings.zh-TW.resx will not have a resource assembly created. Solution: This change renames all *.zh-CN.resx to *.zh-Hans.resx and *.zh-TW.resx to *.zh-Hant.resx. Test Done: Local build with dotnet cli and verified chinese assemblies are created.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #497
Problem:
Refer to dotnet/msbuild#3897 When building with dotnet cli, certain cultures cannot be utilized for resource localization, such as getting localized strings. This impacts both the build process (e.g., identifying and processing resource files) and the lookup of resources at runtime. For example: MyStrings.zh-TW.resx will not have a resource assembly created.
Solution:
This change renames all *.zh-CN.resx to *.zh-Hans.resx and *.zh-TW.resx to *.zh-Hant.resx.
Test Done:
Local build with dotnet cli and verified chinese assemblies are created.