Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] WinUI TeachingTip control #203

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

ShankarBUS
Copy link
Contributor

@ShankarBUS ShankarBUS commented Nov 6, 2020

[WIP]

Fixes #88

@ShankarBUS ShankarBUS changed the title WinUI TeachingTip control [WIP] WinUI TeachingTip control Nov 6, 2020
@ShankarBUS ShankarBUS marked this pull request as draft November 6, 2020 16:47
@ShankarBUS ShankarBUS marked this pull request as ready for review November 6, 2020 16:48
@ShankarBUS ShankarBUS marked this pull request as draft November 6, 2020 16:48
@ShankarBUS
Copy link
Contributor Author

@Kinnara, I can't continue at this point without your help.

I'm struggling with popup placement and transform to visual method.

I need your help.

@ShankarBUS ShankarBUS closed this Nov 17, 2020
@ShankarBUS ShankarBUS deleted the TeachingTip branch November 17, 2020 09:34
@ShankarBUS
Copy link
Contributor Author

I messed up the commits. So, I had to close this PR. I will open a new PR once I finish porting it completely & successfully.

@ShankarBUS
Copy link
Contributor Author

Okay I finally fixed the commits (learnt some git skills ay!). Whew! I could now finally start my work!

@ShankarBUS
Copy link
Contributor Author

I will wait for #225 to be merged because of the intense changes in it.

@ghost1372
Copy link
Contributor

Hi @ShankarBUS Is this PR completed? Or still needs work?
Is it possible to make a video of the steps of porting the controls from winui to wpf?😅
By doing this, more people may be able to help you port

@ShankarBUS
Copy link
Contributor Author

@ghost1372,

Is this PR completed? Or still needs work?

It's obviously incomplete 😅. It needs more work which I can't do anymore....

Is it possible to make a video of the steps of porting the controls from winui to wpf? 😅

As for porting C++/WinRT to C#/WinRT I would recommend watching live coding videos of Martin Zikmund especially the ones where he ports SpinButton to C#/Uno Platform.

As for porting C#/WinRT to C#/.NET/WPF, it is by trial and error. You gotta find which .NET/WPF APIs could replace UWP [XAML] specific APIs. That's where I am currently stuck at 😅.

By doing this, more people may be able to help you port

I would be more than happy if someone could make wealth out of my scraps 😄.

@ghost1372
Copy link
Contributor

thank you @ShankarBUS
you are the best😅

@ghost1372
Copy link
Contributor

@ShankarBUS I wanted to thank you for introducing the video
I tried to port the InfoBar control today And when I was porting the C++ code, I found out that Uno has already ported C++ code to C#/WinRT, so why not port C#/WinRT to C#/WPF?
I tried and was able to port InfoBar control to WPF😁
Of course, the port is not quite accurate, but it is not bad, it is great for my first time
Untitled

I think porting from Uno can be useful

@ShankarBUS
Copy link
Contributor Author

I always use Uno Platform as a reference. But the problem is they customize the C# port for Uno platform. ModernWpf is quite unique. Resource Management, Coding convention are different from that of Uno platform.

So porting directly from the C++/WinRT is better for many reasons.

What you can do is, port directly from WinUI C++/WinRT and keep Uno platform's port as a reference.

@wherewhere
Copy link

Is this really work?
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] TeachingTip
3 participants