gpuav: Fix / 0 in draw mesh indirect validation #9019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI Vulkan-ValidationLayers build queued with queue ID 323679. |
|
CI Vulkan-ValidationLayers build # 18322 running. |
| max_held_draw_cmds = | ||
| static_cast<uint32_t>((draw_buffer_full_size - draw_buffer_offset) / draw_cmds_byte_stride); | ||
| } else { | ||
| max_held_draw_cmds = 1; |
There was a problem hiding this comment.
nit: quote section from the spec: "If drawCount is less than or equal to one, stride is ignored." ?
There was a problem hiding this comment.
Yes good point!
artem-lunarg
approved these changes
Dec 13, 2024
arno-lunarg
force-pushed
the
arno-gpuav-valcmd-fix
branch
from
7806eba to
eae9fd1
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 323712. |
|
CI Vulkan-ValidationLayers build # 18323 running. |
|
CI Vulkan-ValidationLayers build # 18323 passed. |
| @@ -176,3 +176,67 @@ TEST_F(PositiveGpuAVIndirectBuffer, Mesh) { | |||
| m_default_queue->Submit(m_command_buffer); | |||
| m_default_queue->Wait(); | |||
| } | |||
|
|
|||
| TEST_F(PositiveGpuAVIndirectBuffer, MeshSingleCommand) { | |||
There was a problem hiding this comment.
can we add a test for vkCmdDrawIndirect and vkCmdDrawIndexedIndirect which also can have this draw, you only added a code change to the DrawMeshIndirect code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9014