gpu: Reduce post processing already done on CPU #8923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI Vulkan-ValidationLayers build queued with queue ID 309612. |
spencer-lunarg
commented
Nov 26, 2024
| // There is no descriptor aliasing on the CPU, so we automatically know it needs Post Processing | ||
| if (binding_info.second.size() == 1) { | ||
| if (!descriptor_set.ValidateBindingOnGPU(binding, binding_info.second[0].variable->is_dynamic_accessed)) { | ||
| return skip; |
There was a problem hiding this comment.
This is the main change, it will now not re-run the checks/updates on the GPU-AV post process if it was done on the CPU
|
CI Vulkan-ValidationLayers build # 18123 running. |
spencer-lunarg
force-pushed
the
spencer-lunarg-sampler-are-not-fun-
branch
from
d9da293 to
f976bf8
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 309627. |
|
CI Vulkan-ValidationLayers build # 18124 running. |
|
CI Vulkan-ValidationLayers build # 18124 passed. |
arno-lunarg
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
attempt 2 of #8879
(Added many test, which found more bugs 😢 but are tracking in #8922)