Add vk_function_loader.hpp #152
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juan-lunarg
previously requested changes
Oct 17, 2023
charles-lunarg
force-pushed
the
add_function_loader_helper
branch
from
c1b3dd6 to
e946b16
Compare
|
Note that this PR relies on #155 so I will rebase when that is merged. |
charles-lunarg
force-pushed
the
add_function_loader_helper
branch
2 times, most recently
from
8d15953 to
01e678b
Compare
Adds a new header only utility library which contains a loader for the Vulkan-Loader, tables to hold vulkan function pointers, and init functions to fill them out.
charles-lunarg
force-pushed
the
add_function_loader_helper
branch
from
01e678b to
c846501
Compare
juan-lunarg
dismissed
their stale review
Looks good now. But I want Spencer's opinion since this affect VVL/VEL testing.
|
Opened this up a month ago, but the reality is that the solution is to use volk, not write another new library. If there is future interest in library for function loading in this repo, it can be revisited. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new header only utility library which contains a loader for the Vulkan-Loader,
tables to hold vulkan function pointers, and init functions to fill them out.
This is for #73 - will close the issue when VVL & VEL are using this library.