Fix doc for vkuFormatIsXChromaSubsampled #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juan-lunarg
commented
Sep 29, 2023
| @@ -227,7 +227,7 @@ inline bool vkuFormatIsPacked(VkFormat format); | |||
| inline bool vkuFormatRequiresYcbcrConversion(VkFormat format); | |||
|
|
|||
| // Returns whether a VkFormat is XChromaSubsampled | |||
| // This corresponds to formats with _422 in their name | |||
| // This corresponds to formats with _422 or 420 in their name | |||
There was a problem hiding this comment.
@spencer-lunarg does this match your original intent?
There was a problem hiding this comment.
yes, "X Chroma Subsampled" is both, but Y is only 420
spencer-lunarg
approved these changes
Oct 1, 2023
Now the documentation matches the implementation.
charles-lunarg
approved these changes
Oct 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the documentation matches the implementation.