util: Add vk_struct_helper.hpp #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juan-lunarg
suggested changes
Sep 14, 2023
charles-lunarg
force-pushed
the
vk_typemap_helper
branch
from
d8062e9 to
39a7c91
Compare
|
|
|
What about |
|
Thats a good idea due to the inclusion of pNext chain helpers as well. |
charles-lunarg
force-pushed
the
vk_typemap_helper
branch
from
39a7c91 to
f1932e5
Compare
juan-lunarg
suggested changes
Sep 18, 2023
juan-lunarg
reviewed
Sep 18, 2023
charles-lunarg
force-pushed
the
vk_typemap_helper
branch
from
f1932e5 to
ee66bcb
Compare
|
build.gn has been updated. |
charles-lunarg
force-pushed
the
vk_typemap_helper
branch
from
ee66bcb to
6656d65
Compare
juan-lunarg
approved these changes
Sep 19, 2023
charles-lunarg
changed the title
Move the vk_typemap_helper.h file in Vulkan-ValidationLayers over to this repo with a different name to reflect the use of it Changes from that include: * Rename the functions to be more obvious as to what they do * Placing them in the `vku` namespace * Adding the `InitStructHelper` class which deduces the type based on the variable that is being initialized * Compiler error if there is no corresponding sType
charles-lunarg
force-pushed
the
vk_typemap_helper
branch
from
6656d65 to
7fd27de
Compare
|
FWIW I'd start with updating the extension layer instead of vvl. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the vk_struct_helper.h file in Vulkan-ValidationLayers over to this repo.
Changes from that include:
vkunamespaceInitStructHelperclass which deduces the type based on the variable that is being initializedResolves #74