Add SYCL version check #989
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
gmlueck
reviewed
Nov 18, 2024
tests/header/header_test.cpp
Outdated
| @@ -45,6 +45,7 @@ class TEST_NAME : public util::test_base { | |||
| #define TEST_FAIL | |||
| log.note("SYCL_LANGUAGE_VERSION not present"); | |||
| #else | |||
| static_assert(SYCL_LANGUAGE_VERSION, "202012L"); | |||
There was a problem hiding this comment.
Shouldn't this be something like:
static_assert(SYCL_LANGUAGE_VERSION == 202012L)
Followed by a check that the type is really long.
There was a problem hiding this comment.
Followed by a check that the type is really
long.
Something like:
static_assert(std::is_same_v<decltype(SYCL_LANGUAGE_VERSION), long>);
tests/header/header_test.cpp
Outdated
| @@ -45,6 +45,7 @@ class TEST_NAME : public util::test_base { | |||
| #define TEST_FAIL | |||
| log.note("SYCL_LANGUAGE_VERSION not present"); | |||
| #else | |||
| static_assert(SYCL_LANGUAGE_VERSION, "202012L"); | |||
| log.note("SYCL_LANGUAGE_VERSION = %d", static_cast<int>(SYCL_LANGUAGE_VERSION)); | |||
There was a problem hiding this comment.
Not sure if this log message is still useful since we are now checking for a specific value.
There was a problem hiding this comment.
As for me, we can remove this log message due to static_assert.
gmlueck
approved these changes
Nov 19, 2024
|
Ping |
keryell
approved these changes
Nov 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check of SYCL version was added according to agreement, see details:
KhronosGroup/SYCL-Docs#634