-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check forbidden kernel constructs in constant evaluated context #976
Open
keryell
wants to merge
5
commits into
KhronosGroup:main
Choose a base branch
from
keryell:ronan/sycl-pr-388
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keryell
force-pushed
the
ronan/sycl-pr-388
branch
from
October 30, 2024 21:52
0266d6d
to
8f5219d
Compare
There are a lot of restrictions for kernel code, except when present in a constant evaluated context. This is a test corresponding to the specification clarification introduced by PR KhronosGroup/SYCL-Docs#388
keryell
force-pushed
the
ronan/sycl-pr-388
branch
from
October 30, 2024 21:53
8f5219d
to
b3ec4b2
Compare
gmlueck
reviewed
Oct 31, 2024
bader
reviewed
Nov 14, 2024
KhronosGroup/SYCL-Docs#388 was approved to merge. |
gmlueck
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a lot of restrictions for kernel code, except when present in a constant evaluated context.
This is a test corresponding to the specification clarification introduced by PR KhronosGroup/SYCL-Docs#388