Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split conformant product fields in submission template #966

Merged
merged 4 commits into from
Oct 31, 2024
Merged

Split conformant product fields in submission template #966

merged 4 commits into from
Oct 31, 2024

Conversation

steffenlarsen
Copy link
Contributor

@steffenlarsen steffenlarsen commented Oct 22, 2024 •
edited
Loading

This commit splits one of the fields in the "Conformant Product" and "Conformance submission details" sections of the submission_details_template file. This brings the fields closer in line with the conformant products page.

@steffenlarsen
Split conformant product fields in submission template
4f939a9 
This commit splits one of the fields in the "Conformant Product" section
of the submission_details_template file. This brings the fields closer
in line with the conformant products page.

Signed-off-by: Larsen, Steffen <[email protected]>
@steffenlarsen steffenlarsen requested a review from a team as a code owner October 22, 2024 08:35
AerialMantis
AerialMantis approved these changes Oct 22, 2024
View reviewed changes
Copy link
Collaborator

@AerialMantis AerialMantis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

conformance/submission_details_template.txt Outdated Show resolved Hide resolved
conformance/submission_details_template.txt Outdated Show resolved Hide resolved
@steffenlarsen steffenlarsen added the Agenda To be discussed during a SYCL committee meeting label Oct 22, 2024
KornevNikita
KornevNikita reviewed Oct 29, 2024
View reviewed changes
Copy link
Contributor

@KornevNikita KornevNikita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering, should we also update the block above?

Target SYCL backend:
Target SYCL platform:
Target SYCL device:

in # Conformance submission details.

@gmlueck
Copy link
Contributor

gmlueck commented Oct 29, 2024

It does seem like it would be clearer if the "Conformance submission details" section had the same format as "Conformant products". We could change "Conformance submission details" to look like:

SYCL implementation version:
Device:
Backend / platform:
Host architecture:
Host operating system and version:
Host toolchain and version:

(I.e. the same as "Conformant products", but the entries are singular because you submit a conformance report based on a single run of the CTS.)

@bader bader mentioned this pull request Oct 29, 2024
Merged
keryell
keryell approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@keryell keryell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@tomdeakin
Copy link
Contributor

WG approved to merge.

@tomdeakin tomdeakin merged commit 4ece91c into KhronosGroup:main Oct 31, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KornevNikita KornevNikita KornevNikita left review comments

@AerialMantis AerialMantis AerialMantis approved these changes

@gmlueck gmlueck gmlueck approved these changes

@keryell keryell keryell approved these changes

Assignees
No one assigned
Labels
Agenda To be discussed during a SYCL committee meeting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@steffenlarsen @gmlueck @tomdeakin @keryell @AerialMantis @KornevNikita