Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove [[noreturn]] attribute causing UB. #780

Merged
merged 1 commit into from
Aug 10, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions tests/sycl_external/sycl_external_separate_unit.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,8 @@ SYCL_EXTERNAL void before_aspect_host<sycl::aspect::accelerator>(
}

template <sycl::aspect aspect>
[[sycl::device_has(aspect)]] SYCL_EXTERNAL [[noreturn]] void
between_aspects_device(const accT& acc);
[[sycl::device_has(aspect)]] SYCL_EXTERNAL void between_aspects_device(
const accT& acc);
template <>
SYCL_EXTERNAL void between_aspects_device<sycl::aspect::cpu>(const accT& acc) {
acc[0] = value;
Expand All @@ -88,8 +88,8 @@ SYCL_EXTERNAL void between_aspects_device<sycl::aspect::accelerator>(
acc[0] = value;
}
template <sycl::aspect aspect>
[[sycl::device_has(aspect)]] SYCL_EXTERNAL [[noreturn]] void
between_aspects_host(hostAccT& acc);
[[sycl::device_has(aspect)]] SYCL_EXTERNAL void between_aspects_host(
hostAccT& acc);
template <>
SYCL_EXTERNAL void between_aspects_host<sycl::aspect::cpu>(hostAccT& acc) {
acc[0] = value;
Expand Down