Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent signed integer overflow in check_scan_over_group #776

Merged
merged 10 commits into from
Sep 13, 2023
Merged

Prevent signed integer overflow in check_scan_over_group #776

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
e095b9d
Prevent signed integer overflow in `check_scan_over_group`
0x12CC Aug 2, 2023
f733e0a
Merge branch 'SYCL-2020' into overflow_check
0x12CC Aug 2, 2023
f4c4682
Remove large test case from `check_scan`
0x12CC Aug 9, 2023
a7a3157
Merge branch 'SYCL-2020' into overflow_check
0x12CC Aug 9, 2023
ebf19b2
Remove large test case from `check_scan`
0x12CC Aug 9, 2023
a300999
Fixes test sizes and use `REQUIRE` macro
0x12CC Aug 10, 2023
f6e88f4
Merge branch 'SYCL-2020' into overflow_check
0x12CC Aug 10, 2023
e1fd71d
Fix `REQUIRE` condition and update sizes
0x12CC Aug 10, 2023
fda1ad5
Merge branch 'SYCL-2020' into overflow_check
0x12CC Aug 22, 2023
aae7ce3
Merge branch 'SYCL-2020' into overflow_check
0x12CC Aug 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions tests/group_functions/group_scan.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ struct joint_scan_group {

sycl::nd_range<D> executionRange(work_group_range, work_group_range);

const size_t sizes[3] = {5, work_group_size / 2, 3 * work_group_size};
const size_t sizes[2] = {5, 2};
for (size_t size : sizes) {
check_scan<D, T, U>(queue, size, executionRange, OperatorT(), op_name,
false);
Expand Down Expand Up @@ -257,7 +257,7 @@ struct init_joint_scan_group {

size_t work_group_size = work_group_range.size();

const size_t sizes[3] = {5, work_group_size / 2, 3 * work_group_size};
const size_t sizes[2] = {5, 2};
for (size_t size : sizes) {
check_scan<D, T, U, I>(queue, size, executionRange, OperatorT(),
op_name, true);
Expand Down Expand Up @@ -385,6 +385,9 @@ template <int D, typename T, typename U = T, typename OpT>
void check_scan_over_group(sycl::queue& queue, sycl::range<D> range, OpT op,
const std::string& op_name, bool with_init) {
auto range_size = range.size();
REQUIRE(((range_size * (range_size + 1) / 2) + T(init)) <=
std::numeric_limits<T>::max());

ScanOverGroupDataStruct<T, U> host_data{range_size};
{
auto ref_input_sycl = host_data.create_ref_input_buffer();
Expand Down