Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable invalid vec::as test cases #764

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Conversation

0x12CC
Copy link
Contributor

@0x12CC 0x12CC commented Jul 27, 2023

Disable check_vector_as comparisons for cases where the size of the elements differs after conversion. This matches the restriction described in KhronosGroup/SYCL-Docs#447.

Disable `check_vector_as` comparisons for cases where the size of the
elements differs after conversion. This matches the restriction
described in KhronosGroup/SYCL-Docs#447.

Signed-off-by: Michael Aziz <[email protected]>
Copy link
Member

@keryell keryell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@bader
Copy link
Contributor

bader commented Aug 17, 2023

@0x12CC, KhronosGroup/SYCL-Docs#447 has been merged. Is this PR ready for review?

@0x12CC 0x12CC marked this pull request as ready for review August 17, 2023 22:28
@0x12CC 0x12CC requested a review from a team as a code owner August 17, 2023 22:28
@bader bader merged commit 2c00dc2 into KhronosGroup:SYCL-2020 Aug 17, 2023
8 checks passed
@0x12CC 0x12CC deleted the vec_as branch August 17, 2023 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants