POC: migrate expression widget to latest version in PerseusItem parser #1908
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This demonstrates how we can upgrade/migrate widget options in the parsing
code, obviating the need for
propUpgrades
.The fact that
version
is an object makes this really annoying becauseTypeScript can't discriminate unions based on nested properties like
version.major
. Given that constraint, I think the approach I came up with isreasonable, but I'm certainly open to feedback on how to improve it.
Issue: LEMS-2582
Test plan:
yarn test